Skip to content

Remove UDP_stubs.h #9413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cmcfarlen merged 6 commits into from
Feb 16, 2023
Merged

Remove UDP_stubs.h #9413

cmcfarlen merged 6 commits into from
Feb 16, 2023

Conversation

@cmcfarlen
Copy link
Contributor

@cmcfarlen cmcfarlen commented Feb 15, 2023

Followup to #9401

@cmcfarlen cmcfarlen added this to the 10.0.0 milestone Feb 15, 2023
@cmcfarlen cmcfarlen requested a review from zwoop February 15, 2023 19:49
bneradt
bneradt requested changes Feb 15, 2023
View reviewed changes
bneradt
bneradt requested changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@bneradt bneradt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for cleaning up the build.

@zwoop
Copy link
Contributor

zwoop commented Feb 15, 2023 •
edited
Loading

Curious, does this fix the make check target on macOS? Or do we need to cleanup more with the Inline.cc.

@maskit
Copy link
Member

maskit commented Feb 15, 2023

does this fix the make check target on macOS?

It works for me even without this change.

@zwoop
Copy link
Contributor

zwoop commented Feb 15, 2023

does this fix the make check target on macOS?

It works for me even without this change.

Weird, it fails on my mac and on the CI :/.

@cmcfarlen
Copy link
Contributor Author

cmcfarlen commented Feb 15, 2023

I tested on Mac, Linux, and the ci docker image. I think it's good. I would like to cleanup more Inline.cc as I don't believe it buys us anything anymore.

bneradt
bneradt approved these changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@bneradt bneradt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@bneradt
Copy link
Contributor

bneradt commented Feb 15, 2023

[approve ci]

zwoop
zwoop requested changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@zwoop zwoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to address those removals that accidentally snuck in.

@cmcfarlen
Copy link
Contributor Author

cmcfarlen commented Feb 16, 2023

[approve ci]

@cmcfarlen
Copy link
Contributor Author

cmcfarlen commented Feb 16, 2023

I think we need to address those removals that accidentally snuck in.

I restored the doc line and the doxygen comments. Was there something else?

@cmcfarlen cmcfarlen requested a review from zwoop February 16, 2023 03:06
@cmcfarlen cmcfarlen merged commit 2402444 into apache:master Feb 16, 2023
@cmcfarlen cmcfarlen deleted the remove-udp-stubs branch February 16, 2023 16:45
@JosiahWI JosiahWI mentioned this pull request Jul 13, 2023
Closed
cmcfarlen pushed a commit to cmcfarlen/trafficserver that referenced this pull request Jun 3, 2024
@zwoop
Merge remote-tracking branch 'asf/master'
03b605e 
* asf/master: (49 commits)
  Cleanup: removing some traffic_manager leftovers. (apache#9425)
  records.yaml - Add support to load multiple YAML docs from the same file and let traffic_ctl to modify a records.yaml file (apache#9404)
  QUIC-quiche: Use configured disable_active_migration param at quiche transport configuration. (apache#9447)
  records.yaml: Make sure we fail if we found a legacy records.config file. (apache#9435)
  Use TSDbg in webp_transform plugin (apache#9439)
  quic: make sure we create a stream if none available. (apache#9436)
  Fixes comparison with the wrong type (apache#9441)
  On arm64 macOS, do not use pagezero linker flag when using luajit (apache#9430)
  tscore: Remove unneeded and mispelled libswoc reference. (apache#9429)
  Remove UDP_stubs.h (apache#9413)
  Make jsonrcp restricted_api false by default. (apache#9415)
  Histogram: rename members because Zwoop. (apache#9417)
  FileManager string update (apache#9416)
  P_SSLUtils.h include updates (apache#9414)
  libswoc: update build support to fix issues with 10-Dev merge. (apache#9397)
  QUIC: Remove hardcoded quiche set_initial_max_streams and use config values instead. (apache#9412)
  Fixes the compile to work with LLVM15 (apache#9410)
  update cmake for rpc and swoc (apache#9409)
  Removes the UglyStub file (apache#9401)
  TSan: Make Thread::cur_time thread local (apache#9184)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zwoop zwoop zwoop approved these changes

@bneradt bneradt bneradt approved these changes

Assignees

@cmcfarlen cmcfarlen

Labels

Cleanup

Projects

None yet

Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@cmcfarlen @zwoop @maskit @bneradt